Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ssr usage issue #2244

Merged
merged 1 commit into from
Sep 12, 2023
Merged

fix: ssr usage issue #2244

merged 1 commit into from
Sep 12, 2023

Conversation

SavvyShah
Copy link
Contributor

Fix usage issue with SSR using vue-slider-component.

Notion card

@github-actions github-actions bot added the vue label Aug 29, 2023
mohdashraf010897
mohdashraf010897 approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@mohdashraf010897 mohdashraf010897 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM

with-ssr example is breaking and might be(very unlikely though) something to do with the PR.

@mohdashraf010897 mohdashraf010897 merged commit 2fd0adc into next Sep 12, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohdashraf010897 mohdashraf010897 mohdashraf010897 approved these changes

Assignees
No one assigned
Labels
vue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SavvyShah @mohdashraf010897