Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: document suggestions #2242

Merged
merged 55 commits into from
Sep 14, 2023
Merged

feat: document suggestions #2242

merged 55 commits into from
Sep 14, 2023

Conversation

SavvyShah
Copy link
Contributor

@SavvyShah SavvyShah commented Aug 10, 2023

Notion: Recent Document Suggestions

  • Document Suggestions support: Get recent documents searched for the user

ReactiveCore PR
Docs PR

Adds snapshot tests for recent searchbox changes

@siddharthlatest siddharthlatest changed the base branch from next to fix-ai-issues August 23, 2023 05:25
@siddharthlatest siddharthlatest changed the base branch from fix-ai-issues to next September 4, 2023 05:32
Copy link
Member

@mohdashraf010897 mohdashraf010897 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to the requested changes alongside the review for playground PRs.

One thing I am explicitly highlighting -

  • Web: regression -> the feedback footer is shown even when streaming of AI answer is happening.

The expectations are

  • Code change
    • Loom explaining the code changes.
  • Loom using the playrgound deployed previews(not locally) covering
    • main effect
    • please demo the AI related stories as well very thoroughly.

packages/maps/examples/GeoDistanceDropdown/package.json Outdated Show resolved Hide resolved
packages/maps/examples/GeoDistanceSlider/package.json Outdated Show resolved Hide resolved
packages/maps/examples/QuickStartStep1/package.json Outdated Show resolved Hide resolved
packages/maps/examples/QuickStartStep2/package.json Outdated Show resolved Hide resolved
packages/maps/examples/ReactiveMap/package.json Outdated Show resolved Hide resolved
packages/web/src/components/search/SearchBox.js Outdated Show resolved Hide resolved
packages/web/src/components/search/SearchBox.js Outdated Show resolved Hide resolved
});


it('should render AI response & askButton & enterButton', async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const renderAskButtonElement = () => {
const { AIUIConfig, innerClass } = props;

We should change the class names for askbutton from enter-btn or enter-button-wrapper to ask-btn and ask-button-wrapper, please update the snapshot post this change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should I do here?

packages/web/src/components/search/SearchBox.test.js Outdated Show resolved Hide resolved
packages/vue/src/components/search/SearchBox.jsx Outdated Show resolved Hide resolved
Copy link
Member

@mohdashraf010897 mohdashraf010897 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SavvyShah Please address every review comment.

packages/vue/src/components/search/SearchBox.jsx Outdated Show resolved Hide resolved
packages/web/src/components/search/SearchBox.js Outdated Show resolved Hide resolved
packages/web/src/components/search/TextWithTooltip.js Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SavvyShah REfer to comment made for vue counterpart, this util function could be exported out from reactivecore

@@ -6,8 +6,8 @@
"author": "metagrover",
"license": "Apache-2.0",
"dependencies": {
"@appbaseio/reactivemaps": "4.0.0",
"@appbaseio/reactivesearch": "4.0.5",
"@appbaseio/reactivemaps": "4.0.0-rc",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SavvyShah any updates here?

@SavvyShah SavvyShah merged commit 5dac1d8 into next Sep 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants