-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: document suggestions #2242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refer to the requested changes alongside the review for playground PRs.
One thing I am explicitly highlighting -
- Web: regression -> the feedback footer is shown even when streaming of AI answer is happening.
The expectations are
- Code change
- Loom explaining the code changes.
- Loom using the playrgound deployed previews(not locally) covering
- main effect
- please demo the AI related stories as well very thoroughly.
}); | ||
|
||
|
||
it('should render AI response & askButton & enterButton', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reactivesearch/packages/web/src/components/search/SearchBox.js
Lines 1061 to 1062 in acb9c23
const renderAskButtonElement = () => { | |
const { AIUIConfig, innerClass } = props; |
We should change the class names for askbutton from enter-btn or enter-button-wrapper to ask-btn and ask-button-wrapper, please update the snapshot post this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should I do here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SavvyShah Please address every review comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SavvyShah REfer to comment made for vue counterpart, this util function could be exported out from reactivecore
site/demos/airbeds/package.json
Outdated
@@ -6,8 +6,8 @@ | |||
"author": "metagrover", | |||
"license": "Apache-2.0", | |||
"dependencies": { | |||
"@appbaseio/reactivemaps": "4.0.0", | |||
"@appbaseio/reactivesearch": "4.0.5", | |||
"@appbaseio/reactivemaps": "4.0.0-rc", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SavvyShah any updates here?
Notion: Recent Document Suggestions
ReactiveCore PR
Docs PR
Adds snapshot tests for recent searchbox changes