Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests for route53 #71

Merged

Conversation

suzana-nesic
Copy link
Contributor

Part of APPSRE-6308

Signed-off-by: Suzana Nesic snesic@redhat.com

Signed-off-by: Suzana Nesic <snesic@redhat.com>
@janboll
Copy link
Contributor

janboll commented Oct 6, 2022

Thank you for adding tests for route53! Any chance of adding tests for the *WithBackoff methods? 😄

Copy link
Contributor

@janboll janboll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding these tests!
Please remove the debugging statements, after that feel free to merge and promote.

pkg/route53_test.go Outdated Show resolved Hide resolved
@suzana-nesic suzana-nesic merged commit db34ad0 into app-sre:master Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants