Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use default credential management #63

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

wanix
Copy link
Contributor

@wanix wanix commented Sep 12, 2022

Instead of using static credentials only, I propose to use the default credentials management which includes static ones, but also assume roles and service accounts for Kubernetes usage.

This PR is a split from #62

@app-sre-bot
Copy link

Can one of the admins verify this patch?

@wanix wanix mentioned this pull request Sep 12, 2022
@janboll
Copy link
Contributor

janboll commented Sep 12, 2022

ok to test

Copy link
Contributor

@patjlm patjlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@patjlm patjlm merged commit 4db9d83 into app-sre:master Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants