Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use subgraph.name attribute not apollo.subgraph.name #5012

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

garypen
Copy link
Contributor

@garypen garypen commented Apr 24, 2024

The DD exporter does some explicit mapping of attributes and was using a value "apollo.subgraph.name" that the latest versions of the router don't use. The correct choice is "subgraph.name".

Update the mapping to reflect this change.

The DD exporter does some explicit mapping of attributes and was using a
value "apollo.subgraph.name" that the latest versions of the router
don't use. The correct choice is "subgraph.name".

Update the mapping to reflect this change.
@garypen garypen self-assigned this Apr 24, 2024
@garypen garypen requested a review from BrynCooke April 24, 2024 13:15

This comment has been minimized.

@router-perf
Copy link

router-perf bot commented Apr 24, 2024

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • large-request - Stress test with a 1 MB request payload
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xlarge-request - Stress test with 10 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • no-graphos - Basic stress test, no GraphOS.
  • reload - Reload test over a long period of time at a constant rate of users
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • const - Basic stress test that runs with a constant number of users

@garypen garypen enabled auto-merge (squash) April 24, 2024 13:17
@garypen garypen merged commit 48867b6 into dev Apr 24, 2024
13 of 14 checks passed
@garypen garypen deleted the garypen/ROUTER-236/dd-mapping branch April 24, 2024 14:45
garypen added a commit that referenced this pull request Apr 24, 2024
The DD exporter does some explicit mapping of attributes and was using a
value "apollo.subgraph.name" that the latest versions of the router
don't use. The correct choice is "subgraph.name".

Update the mapping to reflect this change.
@@ -29,7 +29,7 @@ lazy_static! {
map.insert("request", "http.route");
map.insert("supergraph", "graphql.operation.name");
map.insert("query_planning", "graphql.operation.name");
map.insert("subgraph", "apollo.subgraph.name");
map.insert("subgraph", "subgraph.name");
Copy link

@Samjin Samjin Apr 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could have spot this by ourself. Thanks Gary! 👍

Geal pushed a commit that referenced this pull request Apr 30, 2024
The DD exporter does some explicit mapping of attributes and was using a
value "apollo.subgraph.name" that the latest versions of the router
don't use. The correct choice is "subgraph.name".

Update the mapping to reflect this change.
@BrynCooke BrynCooke mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants