Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the opentelemetry library to 0.19 to fix the problem ignore da… #3147

Conversation

iceycake
Copy link

@iceycake iceycake commented May 25, 2023

Description here
According to this thread (open-telemetry/opentelemetry-rust#876), the latest opentelemetry-datadog library should fix the problem that apollo router not sending tracing config to datadog

Fixes #1162
#1162 (comment)

Checklist

Complete the checklist (and note appropriate exceptions) before a final PR is raised.

  • [] Changes are compatible[^1]
  • Documentation[^2] completed
  • Performance impact assessed and acceptable
  • Tests added and passing[^3]
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

[^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or ask for it to be labeled) as manual test

@apollo-cla
Copy link

@iceycake: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@router-perf
Copy link

router-perf bot commented May 25, 2023

CI performance tests

  • const - Basic stress test that runs with a constant number of users
  • no-graphos - Basic stress test, no GraphOS.
  • step - Basic stress test that steps up the number of users over time
  • reload - Reload test over a long period of time at a constant rate of users
  • xlarge-request - Stress test with 10Mb request payload
  • large-request - Stress test with a 1Mb request payload
  • xxlarge-request - Stress test with 100Mb request payload

@Geal
Copy link
Contributor

Geal commented May 26, 2023

hi, thanks for the PR. Unfortunately, it will involve a bit more that updating that one dependency, because it needs a tracing-opentelemetry update too, and those generally require some work (context: #2878 ). We were waiting for a new tracing-opentelemetry version, that was just released 3 days ago

@iceycake
Copy link
Author

@Geal Should we close this PR?

@Geal
Copy link
Contributor

Geal commented May 26, 2023

Yes, for now. You can follow the other issue, we'll post updates there

@iceycake iceycake closed this May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namespace not set when sending *directly* to Datadog
3 participants