Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics reporting isn't working correctly for OTLP and datadog on dev #3242

Closed
garypen opened this issue Jun 8, 2023 · 5 comments
Closed

Comments

@garypen
Copy link
Contributor

garypen commented Jun 8, 2023

metrics reporting for the router exporting via OTLP and observing in datadog is not working correctly following the 0.19.0 otel update.

@garypen garypen changed the title metrics reporting isn't working correctly for OTLP and datadog metrics reporting isn't working correctly for OTLP and datadog on dev Jun 8, 2023
@garypen garypen pinned this issue Jun 9, 2023
@garypen
Copy link
Contributor Author

garypen commented Jun 9, 2023

If there is no hotfix for this before we want to make our next release, we will need to consider reverting the otel 0.19.0 PR.

@o0Ignition0o
Copy link
Contributor

No hotfix yet unfortunately, as discussed I will revert the pr and reopen the related issues

@o0Ignition0o
Copy link
Contributor

o0Ignition0o commented Jun 15, 2023

For more context, metrics don't properly flush when the router reloads (on schema updates or configuration change if hot reload is enabled)

image

The next release will provide us with the primitive we need to successfully update.

@o0Ignition0o
Copy link
Contributor

Unpinning this since the tip of dev and the latest release uses otel 0.18

@o0Ignition0o o0Ignition0o unpinned this issue Jun 20, 2023
@o0Ignition0o
Copy link
Contributor

Closing because we fixed it \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants