Handling user logout and registering gql tag

[tomitrescak]

This pull request handles:

• the removal of user from the context on server upon logout
• registration of gal tag on client

[lorensr]

Thanks Tomas! I didn't add user to context because when we add userId caching #6, we won't always have fetched the user, and ideally we won't be fetching the user every time, so as to improve latency. I think the best way to get the user is #4.

[lorensr]

Stylistically I prefer not having comments that mainly repeat the code. In this case, I'd either assume the reader knows what a gql tag is or change the comment to maybe // setup query template literal tag, probably former

[tomitrescak]

Can you elaborate on #4 for user caching? I actually created buy own caching mechanism, but it's very silly. would love to have something more robust.

[lorensr]

Sure, something like this:

USER_CACHE_MAX = 1000
cache = lruCache(config.userCacheMax || USER_CACHE_MAX)

// inside apollo options function
cacheEntry = cache.get req.headers.authorization
if cacheEntry.user 
  isExpired = cacheEntry.expiresAt < new Date()
  if not isExpired
    options.context = {user}
else
  updateCache = (user) ->
    cache.set req.headers.authorization,
      user: user
      expiresAt: // todo

  cursor = Meteor.users.find({"services.resume.loginTokens.hashedToken": hashedToken})
  user = await cursor.findOne()
  if user
    updateCache(user)
    options.context = {user}

    handle = cursor.observe
      changed(newDoc, oldDoc): ->
        if token expired
          cache.del(req.headers.authorization)
          handle.stop()
        else
          if cache.has req.headers.authorization
            updateCache(newDoc)
          else
            handle.stop()
      removed(oldDoc): ->
        cache.del(req.headers.authorization)
        handle.stop()

[lorensr]

Using https://www.npmjs.com/package/lru-cache

[tomitrescak]

@lorensr you are a star! Thank you!

[stubailo]

registerGqlTag is now deprecated, so we shouldn't use it anymore.

[tomitrescak]

@stubailo what's the substitute?

[tomitrescak]

@stubailo what's the substitute?

[lorensr]

@tomitrescak #18 (comment)

[tomitrescak]

Nevermind, ... But I liked the central approach ... Call me old fashioned :)

[tomitrescak]

Nevermind, ... But I liked the central approach ... Call me old fashioned :)

[tomitrescak]

Nevermind, ... But I liked the central approach ... Call me old fashioned :)

[tomitrescak]

Nevermind, ... But I liked the central approach ... Call me old fashioned :)

[tomitrescak]

Nevermind, ... But I liked the central approach ... Call me old fashioned :)

[lorensr]

Weird, think your browser got into a submit loop 😆

[tomitrescak]

Oh, sh.t I'm in Eastern Europe in a mountain cottage on Edge connection, things always get interesting this way I guess. Sorry! Going offline now.