Make fallback globalThis process object writable #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fall more in-line with `global.process` in Node, this commit adjusts the created fallback `globalThis.process` object to be writable (and configurable). This helps address issues like: apollographql/apollo-client-devtools#455
benjamn
approved these changes
Mar 15, 2021
hwillson
added a commit
to apollographql/apollo-client
that referenced
this pull request
Mar 15, 2021
To bring in the changes outlined in: apollographql/invariant-packages#91
benjamn
pushed a commit
to apollographql/apollo-client
that referenced
this pull request
Mar 15, 2021
hwillson
added a commit
to apollographql/apollo-client-devtools
that referenced
this pull request
Mar 15, 2021
This will allow us to pull in the changes from apollographql/invariant-packages#91. Fixes #455 Fixes #457
hwillson
added a commit
to apollographql/apollo-client-devtools
that referenced
this pull request
Mar 15, 2021
This will allow us to pull in the changes from apollographql/invariant-packages#91. Fixes #455 Fixes #457
benjamn
added a commit
that referenced
this pull request
Mar 17, 2021
Follow-up to #91. Some websites use the existence of a global process object to feature-detect the Node.js host environment, so it's not safe for this package to initialize globalThis.process when it does not already exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fall more in-line with
global.processin Node, this commit adjusts the created fallbackglobalThis.processobject to bewritable (and configurable). This helps address issues like: apollographql/apollo-client-devtools#455