Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate proper errors for invalid context name #3041

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

clenfest
Copy link
Contributor

We were triggering an assert in extractSubgraphsFromSupergraph because we weren't properly detecting an invalid name at validation time. Make sure regex matches.

…e we weren't properly detecting an invalid name at validation time. Make sure regex matches.
@clenfest clenfest requested a review from a team as a code owner June 19, 2024 02:18
Copy link

changeset-bot bot commented Jun 19, 2024

⚠️ No Changeset found

Latest commit: f353605

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for apollo-federation-docs canceled.

Name Link
🔨 Latest commit f353605
🔍 Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/66723fdf96ba4000087570ab

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@trevor-scheer trevor-scheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! The underscore validation right before seems redundant now but also not harmful.

@clenfest clenfest merged commit b258406 into main Jun 20, 2024
19 checks passed
@clenfest clenfest deleted the clenfest/empty_context_name branch June 20, 2024 16:32
Meschreiber pushed a commit that referenced this pull request Jul 9, 2024
We were triggering an assert in extractSubgraphsFromSupergraph because
we weren't properly detecting an invalid name at validation time. Make
sure regex matches.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants