Fix dependency problems causing build issues #952
Conversation
The package / package-lock files have existed in a semi-broken state for some time. This resolves at least enough of the issues to allow a clean "npm install" without the build breaking.
| @@ -75,12 +72,8 @@ | |||
| "@types/recursive-readdir": "2.2.0", | |||
| "@types/rimraf": "2.0.2", | |||
| "@types/ws": "6.0.1", | |||
| "babel-loader": "7.1.5", | |||
There was a problem hiding this comment.
Most of these are leftover from the query runner webview / webpack stuff.
| "chai": "4.2.0", | ||
| "css-loader": "1.0.1", | ||
| "graphql": "14.0.2", |
There was a problem hiding this comment.
This is not needed at the root.
| @@ -91,17 +84,12 @@ | |||
| "nock": "10.0.6", | |||
| "prettier": "1.16.1", | |||
| "rimraf": "^2.6.3", | |||
| "style-loader": "0.23.1", | |||
| "symlink-dir": "2.0.2", | |||
There was a problem hiding this comment.
This was moved from deps to devDeps
| @@ -46,10 +46,7 @@ | |||
| "apollo-codegen-typescript": "file:packages/apollo-codegen-typescript", | |||
| "apollo-env": "file:packages/apollo-env", | |||
| "apollo-language-server": "file:packages/apollo-language-server", | |||
| "glob": "^7.1.3", | |||
There was a problem hiding this comment.
This is not needed at the root
| @@ -33,8 +33,8 @@ | |||
| "cosmiconfig": "^5.0.6", | |||
| "dotenv": "^6.1.0", | |||
| "glob": "^7.1.3", | |||
| "graphql": "^14.0.2", | |||
| "graphql-tag": "^2.10.0", | |||
| "graphql": "14.0.2", | |||
There was a problem hiding this comment.
Pin this everywhere to guarantee same version. This is something we want to be very careful about always.
There was a problem hiding this comment.
Apparently this causes trouble over in #630. Would a peerDependency not work for this?
| @@ -47,25 +47,22 @@ | |||
| "apollo-engine-reporting": "0.2.1", | |||
| "apollo-env": "file:../apollo-env", | |||
| "apollo-language-server": "file:../apollo-language-server", | |||
| "apollo-server-core": "^2.3.4", | |||
There was a problem hiding this comment.
We want to kill this ASAP, but it works for now. I'll spin an issue out of this to circle back. For now, it solves the problem.
I thought the apollo-engine-reporting issue was resolved, based on ability to build. It turns out, the new release still isn't requiring apollo-server-core like it should be (see package-lock.json).
| "chalk": "^2.4.1", | ||
| "cli-ux": "^4.3.0", | ||
| "env-ci": "^3.0.0", | ||
| "gaze": "^1.1.3", | ||
| "git-parse": "^1.0.3", | ||
| "git-rev-sync": "^1.12.0", | ||
| "glob": "^7.1.2", | ||
| "graphql": "^14.0.2", | ||
| "graphql": "14.0.2", |
There was a problem hiding this comment.
Pin this as mentioned above.
| "tty": "^1.0.1", | ||
| "vscode-uri": "^1.0.6" | ||
| }, | ||
| "devDependencies": { |
There was a problem hiding this comment.
Only need this at the root.
| "graphql-tag": "^2.9.2", | ||
| "heroku-cli-util": "^8.0.9", | ||
| "listr": "^0.14.1", | ||
| "lodash": "^4.17.10", | ||
| "rimraf": "^2.6.2", |
There was a problem hiding this comment.
This only needs to be a devDep at the top level.
| @@ -23,15 +23,15 @@ | |||
| "test": "node ./lib/testRunner/vscode-test-script.js" | |||
| }, | |||
| "engines": { | |||
| "vscode": "^1.28.0" | |||
| "vscode": "^1.30" | |||
There was a problem hiding this comment.
Bumped vscode and related to resolve version mismatch issues w.r.t each other. These aren't specified as peerDeps but it seems they should be, as one was breaking the other.
The package / package-lock files have existed in a semi-broken state for some time. This resolves at least enough of the issues to allow a clean "npm install" without the build breaking (a previous symptom being "npm ci" worked but "npm install" did not).
Realistically, this is just a step in the right direction to get the repo into a better and more "developable" state than it currently is in. There are likely some other dependency issues to be resolved.