Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate client:codegen command #2619

Merged
merged 2 commits into from
May 20, 2022
Merged

Conversation

trevor-scheer
Copy link
Member

Related: #2614

This change officially deprecates the codegen utility in the Apollo CLI. The recommendation going forward is to use the graphql-code-generator utility.

For iOS (for which there is no existing replacement): patch fixes will still be entertained and released on the v2.x line, but no further development will be done unless it's necessary. Apollo iOS intends to release their own codegen in the relatively near future.

While we do encourage moving away from the CLI as quickly as possible, I'm sympathetic to the fact that a change might not be feasible right away. I've included the --suppressDeprecationWarning flag in order to silence the console output when running the client:codegen command.

I haven't added tests for the printing of this command, but I did test locally to ensure the notice is printed (and is also suppressible with the flag).

@trevor-scheer trevor-scheer requested a review from hwillson May 20, 2022 01:53
@changeset-bot
Copy link

changeset-bot bot commented May 20, 2022

🦋 Changeset detected

Latest commit: c330b37

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
apollo Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @trevor-scheer - thanks!

@trevor-scheer trevor-scheer merged commit 573ff2b into master May 20, 2022
@trevor-scheer trevor-scheer deleted the trevor/deprecate-codegen branch May 20, 2022 22:23
@github-actions github-actions bot mentioned this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants