Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for interface on interfaces to transformSchema #2456

Merged
merged 1 commit into from
Oct 23, 2021

Conversation

IvanGoncharov
Copy link
Member

@IvanGoncharov IvanGoncharov commented Oct 15, 2021

This change fixes transformSchema, which previously left
GraphQLInterface::interfaces field as-is after transforming types.
This meant that interfaces types used implemented by other interfaces
would appear duplicated in the schema.

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@IvanGoncharov IvanGoncharov force-pushed the interfacesOnInterfaces branch from 59b5574 to 39b49ad Compare October 15, 2021 15:49
@hwillson hwillson self-requested a review October 15, 2021 18:11
@hwillson
Copy link
Member

Thanks for this @IvanGoncharov. The NodeJS 14 Windows test is failing because of this:

Image 2021-10-15 at 2 28 24 PM

We're checking to make sure the NODE_VERSION version of 14.16.1 is installed, but after asking to have that version installed, the version that is actually being installed is 14.17.5. So the Assert Node.js version check fails.

It's very strange that nvm use 14.16.1 is picking 14.17.5, but as you mentioned this error isn't caused by your changes. We can look at that separately.

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @IvanGoncharov - thanks!

…formSchema

This change fixes `transformSchema`, which previously left
`GraphQLInterface::interfaces` field as-is after transforming types.
This meant that interfaces types used implemented by other interfaces
would appear duplicated in the schema.
@hwillson hwillson force-pushed the interfacesOnInterfaces branch from 39b49ad to 8c579a2 Compare October 23, 2021 13:12
@hwillson hwillson merged commit 97cfc4e into apollographql:master Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants