Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update graphql to v14 #626

Closed
trevor-scheer opened this issue Oct 10, 2018 · 6 comments
Closed

Update graphql to v14 #626

trevor-scheer opened this issue Oct 10, 2018 · 6 comments
Assignees
@trevor-scheer

Comments

@trevor-scheer
Copy link
Member

This issue is to upgrade packages dependent on graphql-js to v14.

v14 offers some handy utility functions for validating types of nodes.
They'll be useful here: #625
@trevor-scheer trevor-scheer self-assigned this Oct 10, 2018
@justinanastos
Copy link
Contributor

In addition, graphql@^0.13.2 is a dependency. If the consumer has another version of graphql installed, such as 0.14.x, then when the cli parses a schema.json file, it will use 0.14.x and instanceof checks will fail because there's multiple versions of graphql.

I suggest making graphql a peerDependency and setting the version to >^0.13.2 || ^0.14.0.

@justinanastos
Copy link
Contributor

justinanastos commented Oct 10, 2018 •
edited
Loading

☝️ This might require updating the tests to run on both versions, which seems like something we should do anyway.

@daggerjames
Copy link

#624

trevor-scheer added a commit that referenced this issue Oct 12, 2018
@trevor-scheer
Update graphql to version 14 (#624)
ac39108 
Update graphql package + types.
Resolve typescript errors and update snapshots.

Fixes #626

-- Amending commit for a new hash for testing purposes
trevor-scheer added a commit that referenced this issue Oct 12, 2018
@trevor-scheer
Update graphql to version 14 (#624)
c91e5d6 
Update graphql package + types.
Resolve typescript errors and update snapshots.

Fixes #626

-- Amending commit for a new hash for testing purposes
-- 2nd amend
@Slessi
Copy link

Slessi commented Oct 15, 2018

#577

@stevenpetryk
Copy link

#648 as well. These just keep on rolling in, and for some reason people cannot find the original issue for it either.

@stevenpetryk
Copy link

@trevor-scheer I think this also encompasses #630.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trevor-scheer trevor-scheer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@stevenpetryk @Slessi @justinanastos @daggerjames @trevor-scheer