Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Express to 4.21.1 #7937

Closed

Conversation

WilliamForbesJr
Copy link

First, 🌠 thank you 🌠 for taking the time to consider a contribution to Apollo!

Here are some important details to follow:

  • ⏰ Your time is important
    To save your precious time, if the contribution you are making will take more
    than an hour, please make sure it has been discussed in an issue first.
    This is especially true for feature requests!
  • 💡 Features
    Feature requests can be created and discussed within a GitHub Issue. Be
    sure to search for existing feature requests (and related issues!) prior to
    opening a new request. If an existing issue covers the need, please upvote
    that issue by using the 👍 emote, rather than opening a new issue.
  • 🔌 Integrations
    Apollo Server has many web-framework integrations including Express, Koa,
    Hapi and more. When adding a new feature, or fixing a bug, please take a
    peak and see if other integrations are also affected. In most cases, the
    fix can be applied to the other frameworks as well. Please note that,
    since new web-frameworks have a high maintenance cost, pull-requests for
    new web-frameworks should be discussed with a project maintainer first.
  • 🕷 Bug fixes
    These can be created and discussed in this repository. When fixing a bug,
    please try to add a test which verifies the fix. If you cannot, you should
    still submit the PR but we may still ask you (and help you!) to create a test.
  • 📖 Contribution guidelines
    Follow https://github.com/apollographql/apollo-server/blob/main/CONTRIBUTING.md
    when submitting a pull request. Make sure existing tests still pass, and add
    tests for all new behavior.
  • ✏️ Explain your pull request
    Describe the big picture of your changes here to communicate to what your
    pull request is meant to accomplish. Provide 🔗 links 🔗 to associated issues!

We hope you will find this to be a positive experience! Open source contribution can be intimidating and we hope to alleviate that pain as much as possible. Without following these guidelines, you may be missing context that can help you succeed with your contribution, which is why we encourage discussion first. Ultimately, there is no guarantee that we will be able to merge your pull-request, but by following these guidelines we can try to avoid disappointment.

Description

  • Update Express from 4.20.0 to 4.21.1

Resolves: #7936

- Update Express from 4.20.0 to 4.21.1
Copy link

netlify bot commented Oct 11, 2024

👷 Deploy request for apollo-server-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 08b3114

@svc-apollo-docs
Copy link
Collaborator

❌ Docs Preview Failed

Error

HttpError: Resource not accessible by personal access token - https://docs.github.com/rest/commits/statuses#create-a-commit-status

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@WilliamForbesJr WilliamForbesJr changed the title Update Express minor version Update Express to 4.21.1 Oct 11, 2024
@Jens-Rydholm-Humly
Copy link

Is there a plan for merging this PR? Asking because express 4.21.1 fixes a security issue by updating cookie.

@glasser
Copy link
Member

glasser commented Oct 29, 2024

This PR only updates the version of express used when operating in this repo/running CI/etc; it doesn't actually update the dependency of the published @apollo/server on express. I'll make a new PR.

@glasser glasser closed this Oct 29, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apollo-server-express dependency on cookie <7.0 (CVE-2024-47764)
5 participants