chore(op-reg): Drop loglevel-debug use.
#4327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Drop the use of uncommonly used `loglevel-debug`. Removed in the same spirit as was done in the `@apollo/gateway` package (see footer for PR reference) due to general deficiencies and bugs in that chosen implementation and also just because it's widely unutilized (if used at all). Much in the same way as the PR below suggests, this behavior could be opted into if necessary by providing a custom `logger` to the plugin options. While that option doesn't yet exist, a PR would be very much welcome (though it does require juggling some of the conditions around how the "dry-run" mode works and does its logging in a well-defined way. [Ref]: #3896.
glasser
added a commit
that referenced
this pull request
Aug 19, 2020
In 91b8839 @abernix updated package-lock for `@types/express` (something I had also noted happened on a branch I was working on). Soon after, in #4327, that line got dropped from package-lock.json. I'm guessing this caused the issue I started seeing soon afterwards, where I'd get lots of compile errors relating to `@types/express` and other DefinitelyTyped packages it depends on. Turns out the dependencies from `@types/express` are unversioned, but the latest versions of that type package depends on the latest versions of a bunch of other type packages. This commit seems to fix things for me.
glasser
added a commit
that referenced
this pull request
Aug 19, 2020
In 91b8839 @abernix updated package-lock for `@types/express` (something I had also noted happened on a branch I was working on). Soon after, in #4327, that line got dropped from package-lock.json. I'm guessing this caused the issue I started seeing soon afterwards, where I'd get lots of compile errors relating to `@types/express` and other DefinitelyTyped packages it depends on. Turns out the dependencies from `@types/express` are unversioned, but the latest versions of that type package depends on the latest versions of a bunch of other type packages. This commit seems to fix things for me.
glasser
added a commit
that referenced
this pull request
Aug 19, 2020
In 91b8839 @abernix updated package-lock for `@types/express` (something I had also noted happened on a branch I was working on). Soon after, in #4327, that line got dropped from package-lock.json. I'm guessing this caused the issue I started seeing soon afterwards, where I'd get lots of compile errors relating to `@types/express` and other DefinitelyTyped packages it depends on. Turns out the dependencies from `@types/express` are unversioned, but the latest versions of that type package depends on the latest versions of a bunch of other type packages. This commit seems to fix things for me.
glasser
added a commit
that referenced
this pull request
Aug 25, 2020
In 91b8839 @abernix updated package-lock for `@types/express` (something I had also noted happened on a branch I was working on). Soon after, in #4327, that line got dropped from package-lock.json. I'm guessing this caused the issue I started seeing soon afterwards, where I'd get lots of compile errors relating to `@types/express` and other DefinitelyTyped packages it depends on. Turns out the dependencies from `@types/express` are unversioned, but the latest versions of that type package depends on the latest versions of a bunch of other type packages. This commit seems to fix things for me.
glasser
added a commit
that referenced
this pull request
Aug 26, 2020
In 91b8839 @abernix updated package-lock for `@types/express` (something I had also noted happened on a branch I was working on). Soon after, in #4327, that line got dropped from package-lock.json. I'm guessing this caused the issue I started seeing soon afterwards, where I'd get lots of compile errors relating to `@types/express` and other DefinitelyTyped packages it depends on. Turns out the dependencies from `@types/express` are unversioned, but the latest versions of that type package depends on the latest versions of a bunch of other type packages. This commit seems to fix things for me.
abernix
added a commit
that referenced
this pull request
Aug 28, 2020
* chore(deps): specify versions for `@types/express` and friends In 91b8839 @abernix updated package-lock for `@types/express` (something I had also noted happened on a branch I was working on). Soon after, in #4327, that line got dropped from package-lock.json. I'm guessing this caused the issue I started seeing soon afterwards, where I'd get lots of compile errors relating to `@types/express` and other DefinitelyTyped packages it depends on. Turns out the dependencies from `@types/express` are unversioned, but the latest versions of that type package depends on the latest versions of a bunch of other type packages. This commit seems to fix things for me. * Remove a couple type dependencies from `apollo-server-express`. - We don't directly depend on `@types/express-serve-static-core`, so I don't quite understand the addition of those. I seem to not have the flapping of deps without adding it! - We shouldn't need to package the `@types/qs` (or the aforementioned pkg) into the `apollo-server-express` package's non-dev deps because none of those types are exported from our emitted `d.ts` files. Those dependencies should be brought by the corresponding packages if there are transitive dep needs. Co-authored-by: Jesse Rosenberger <git@jro.cc>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Drop the use of uncommonly used
loglevel-debug.Removed in the same spirit as was done in the
@apollo/gatewaypackage (seefooter for PR reference) due to general deficiencies and bugs in that
chosen implementation and also just because it's widely unutilized (if used
at all).
Much in the same way as the PR below suggests, this behavior could be opted
into if necessary by providing a custom
loggerto the plugin options.While that option doesn't yet exist, a PR would be very much welcome (though
it does require juggling some of the conditions around how the "dry-run"
mode works and does its logging in a well-defined way.