Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apollo-server-lambda/src/lambdaApollo no longer errors when event.isBase64Encoded #2600

Closed
wants to merge 2 commits into from
Closed

apollo-server-lambda/src/lambdaApollo no longer errors when event.isBase64Encoded #2600

wants to merge 2 commits into from

Conversation

gobengo
Copy link

@gobengo gobengo commented Apr 21, 2019 •
edited
Loading

Resolves #2599

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@apollo-cla
Copy link

@gobengo: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@gobengo gobengo mentioned this pull request Apr 22, 2019
Closed
@2color
Copy link

2color commented Apr 9, 2020 •
edited
Loading

Any updates on this?

I'm experiencing this same problem and can confirm this PR resolves it.

@abernix abernix closed this Jun 24, 2020
@abernix abernix reopened this Jun 25, 2020
@abernix abernix changed the base branch from master to main June 25, 2020 09:04
@abernix
Copy link
Member

abernix commented Jul 17, 2020

Superseded by #4311.

Thanks for opening this originally though! Should hopefully be fixed in apollo-server-lambda@2.16.0.

@abernix abernix closed this Jul 17, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abernix abernix Awaiting requested review from abernix

@martijnwalraven martijnwalraven Awaiting requested review from martijnwalraven

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

apollo-server-lambda: JSON.parse errors when lambda event.isBase64Encoded=true
4 participants
@gobengo @apollo-cla @2color @abernix