Re-land: Fastify integration from #1971. #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This specific port per integration is pretty brittle to begin with, but it does work. Currently, the fact that it works is facilitated by the fact that most people don't use 5555 (Hapi) and 6666 (Express) for anything. That said, the ever-popular Gatsby uses 8888 by default, so let's use 9999!
Merged
3 tasks
This will allow Lerna to release the first version as `apollo-server-fastify@2.4.2`.
- apollo-cache-control@0.5.1-rc.0 - apollo-datasource-rest@0.3.1-rc.0 - apollo-datasource@0.3.1-rc.0 - apollo-engine-reporting-protobuf@0.2.1-rc.0 - apollo-engine-reporting@1.0.2-rc.0 - apollo-server-azure-functions@2.4.2-rc.0 - apollo-server-cache-memcached@0.3.1-rc.0 - apollo-server-cache-redis@0.3.1-rc.0 - apollo-server-caching@0.3.1-rc.0 - apollo-server-cloud-functions@2.4.2-rc.0 - apollo-server-cloudflare@2.4.2-rc.0 - apollo-server-core@2.4.2-rc.0 - apollo-server-express@2.4.2-rc.0 - apollo-server-fastify@2.4.2-rc.0 - apollo-server-hapi@2.4.2-rc.0 - apollo-server-integration-testsuite@2.4.2-rc.0 - apollo-server-koa@2.4.2-rc.0 - apollo-server-lambda@2.4.2-rc.0 - apollo-server-micro@2.4.2-rc.0 - apollo-server-plugin-base@0.3.2-rc.0 - apollo-server-testing@2.4.2-rc.0 - apollo-server@2.4.2-rc.0 - apollo-tracing@0.5.1-rc.0 - graphql-extensions@0.5.2-rc.0
|
Thank you so much, @addityasingh! Hope you enjoyed your time away. This has been released as Ref: #1971 (comment) |
4 tasks
|
@abernix I'm not sure how to post issues for apollo-server-fastify in particular, so I'm just asking here. Is there a way to access the |
This was referenced May 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a re-staging of #1971 by @rkorrelboom which was already approved and merged, but will need to land again. We're currently waiting on a package naming conflict resolution, as mentioned in #1971 (comment), and it's not worth holding up the rest of the 2.4.0 (#2215) release while we wait. Therefore, I'm opening this PR off the same branch we previously merged, I've re-opened #626 (the issue associated with this feature), and I've reverted the squashed commit of #1971 from the
release-2.4.0branch in preparation for publishing.It's worth pointing out that there is another PR, #1760, which aimed to bring Fastify support that just came to my attention earlier this week. I hadn't noticed that there were two of the almost same implementations in flight! The author of that initial PR, @addityasingh, is the current owner of the
apollo-server-fastifypackage and it seems also went through the npm process to obtain it from its previous owner. I think we need to give credit where credit is due and I've given Git commit history credit (by merging that PR into this PR, but favoring this PR's implementation which has already been reviewed) to @addityasingh to respect their contribution.This PR will remain here until we have movement or updates from either the previous package owner or npm.
Closes #626. Again.