[wip] Full Query Caching #1570
Closed
[wip] Full Query Caching #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also provides inital tests for public vs private cache
ghost
added
the
|
Looking forward to this merge! |
This was referenced Apr 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add full response caching. Currently there are plans for an improved request pipeline, so this is wip. Currently this full response caching only applies to http traffic.
It offers a separate public and private cache that can be configured with the
cacheControlobject. If no cache is specified, then the responses are stored in the default cache. Since caching is opt in, we don't have an easy way to disable the functionality besides creating a cache that always returns null for a get.TODO: