-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@defer & @stream experimental usage & docs #7279
Comments
Fixes #7279 <!-- First, 🌠 thank you 🌠 for taking the time to consider a contribution to Apollo! Here are some important details to follow: * ⏰ Your time is important To save your precious time, if the contribution you are making will take more than an hour, please make sure it has been discussed in an issue first. This is especially true for feature requests! * 💡 Features Feature requests can be created and discussed within a GitHub Issue. Be sure to search for existing feature requests (and related issues!) prior to opening a new request. If an existing issue covers the need, please upvote that issue by using the 👍 emote, rather than opening a new issue. * 🔌 Integrations Apollo Server has many web-framework integrations including Express, Koa, Hapi and more. When adding a new feature, or fixing a bug, please take a peak and see if other integrations are also affected. In most cases, the fix can be applied to the other frameworks as well. Please note that, since new web-frameworks have a high maintenance cost, pull-requests for new web-frameworks should be discussed with a project maintainer first. * 🕷 Bug fixes These can be created and discussed in this repository. When fixing a bug, please _try_ to add a test which verifies the fix. If you cannot, you should still submit the PR but we may still ask you (and help you!) to create a test. * 📖 Contribution guidelines Follow https://github.com/apollographql/apollo-server/blob/main/CONTRIBUTING.md when submitting a pull request. Make sure existing tests still pass, and add tests for all new behavior. * ✏️ Explain your pull request Describe the big picture of your changes here to communicate to what your pull request is meant to accomplish. Provide 🔗 links 🔗 to associated issues! We hope you will find this to be a positive experience! Open source contribution can be intimidating and we hope to alleviate that pain as much as possible. Without following these guidelines, you may be missing context that can help you succeed with your contribution, which is why we encourage discussion first. Ultimately, there is no guarantee that we will be able to merge your pull-request, but by following these guidelines we can try to avoid disappointment. -->
@trevor-scheer little side question, would you happen to know if it's possible to force the package.lock to accept using |
Hey @Banou26, this is a common problem for now - tools don't really support v17 in their peer dependencies. We work around this in our CI using the apollo-server/.circleci/config.yml Line 66 in 610f930
|
Issue Description
When trying to follow the instructions for running
@defer
&@stream
(as per #6827), tried using both the graphql17.0.0-alpha.2
&17.0.0-alpha.1
, the server always returnUnknown directive \"@defer\".
as response.I did also try
16.0.0-experimental-stream-defer.5
, in which case, it didn't throw theUnknown directive \"@defer\".
error but instead just returned an empty result from the http server.Using the
16.0.0-experimental-stream-defer.5
experimental version did allow me to get a response from theexecuteOperation
api, even thought it did not conform to the specs documented in #6827 and returned abody.singleResult
looking likeI'd really like to have some more documentation on how to use these features.
Link to Reproduction
https://github.com/Banou26/apollo-server-issue-7279
Reproduction Steps
accessing the sandbox and sending this request
will result in a
Unknown directive \"@defer\".
errorThe text was updated successfully, but these errors were encountered: