-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@types/express
dependency is missing in apollo-server
package
#6390
Comments
I think that's right, since express.Request is in the API. Will fix along with your other concerns. |
glasser
added a commit
that referenced
this issue
May 5, 2022
Some packages were depending on other packages that were only declared as transitive dependencies. Clean this up by adding appropriate dependencies (or in one case, just re-declaring ValueOrPromise and dropping the apollo-server-types dependency). The peer dep one is a bit funny. But "Y has a peer dep on Z" means "when you install Y you need to install Z", and so if X depends on Y, then when you install X you need to install Z... so sure, that means X needs to have a peer dep on Z too, I guess. Fixes #6389. Fixes #6390. Fixes #6391. Fixes #6392.
glasser
added a commit
that referenced
this issue
May 5, 2022
Some packages were depending on other packages that were only declared as transitive dependencies. Clean this up by adding appropriate dependencies (or in one case, just re-declaring ValueOrPromise and dropping the apollo-server-types dependency). The peer dep one is a bit funny. But "Y has a peer dep on Z" means "when you install Y you need to install Z", and so if X depends on Y, then when you install X you need to install Z... so sure, that means X needs to have a peer dep on Z too, I guess. Fixes #6389. Fixes #6390. Fixes #6391. Fixes #6392.
glasser
added a commit
that referenced
this issue
May 5, 2022
Some packages were depending on other packages that were only declared as transitive dependencies. Clean this up by adding appropriate dependencies (or in one case, just re-declaring ValueOrPromise and dropping the apollo-server-types dependency). The peer dep one is a bit funny. But "Y has a peer dep on Z" means "when you install Y you need to install Z", and so if X depends on Y, then when you install X you need to install Z... so sure, that means X needs to have a peer dep on Z too, I guess. Fixes #6389. Fixes #6390. Fixes #6391. Fixes #6392.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When we try to generate our TS code without
skipLibCheck
, we have this error:Could not find a declaration file for module 'express'
The .d.ts file generated by https://github.com/apollographql/apollo-server/blob/main/packages/apollo-server/src/index.ts needs
@types/express
.We should declare
@types/express
as dependency in theapollo-server
package.The text was updated successfully, but these errors were encountered: