Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Documentation for apollo-server-fastify #5943

Closed
NexWasTaken opened this issue Dec 10, 2021 · 4 comments
Closed

Incorrect Documentation for apollo-server-fastify #5943

NexWasTaken opened this issue Dec 10, 2021 · 4 comments

Comments

@NexWasTaken
Copy link

The documentation on the website for integrating apollo into fastify has incorrect documentation. The return type of fastifyAppClosePlugin i.e. ApolloServerPlugin is not imported from anywhere (and from what I could tell is not even exported by any package).

@NexWasTaken NexWasTaken changed the title Incorrect Document for apollo-server-fastify Incorrect Documentation for apollo-server-fastify Dec 16, 2021
@mannyluvstacos
Copy link
Contributor

Hey there @NexWasTaken!

ApolloServerPlugin is an interface that is exported by apollo-server-plugin-base

I was working on implementing a federated gateway based on fastify and did a little poking around to unblock myself.
I hope this information helps you as well!

mannyluvstacos added a commit to mannyluvstacos/apollo-server that referenced this issue Dec 23, 2021
This PR does the following,
- updates the example for `apollo-server-fastify` to import the ` ApolloServerPlugin` interface from `apollo-server-plugin-base`

This should address apollographql#5943
glasser pushed a commit that referenced this issue Dec 27, 2021
This PR does the following,
- updates the example for `apollo-server-fastify` to import the ` ApolloServerPlugin` interface from `apollo-server-plugin-base`

This should address #5943
@glasser
Copy link
Member

glasser commented Dec 27, 2021

Thanks! Fixed by merging #5966.

The sheer number of packages in this repository is overwhelming. We're planning to publish soon our plan for an Apollo Server 4 that trims it down to one core package (based on other things discussed over the past few years).

@mannyluvstacos
Copy link
Contributor

Thanks! Fixed by merging #5966.

The sheer number of packages in this repository is overwhelming. We're planning to publish soon our plan for an Apollo Server 4 that trims it down to one core package (based on other things discussed over the past few years).

Awesome! I am looking forward to those plans!
Anything folks in the community may be able to help with @glasser?

@glasser
Copy link
Member

glasser commented Dec 29, 2021

I think so! Part of the plan will be (as per #3184) having a single well-defined interface for integrating any web framework with Apollo Server. As part of that, we'll move away from the status quo where the core team needs to actively maintain many specific integrations (despite the fact that we personally only have hands-on production experience with a few of them) to a world where more of the integrations are community-maintained. So one of the biggest ways we can get help from the community will be for folks who are passionate about particular web frameworks to help/lead the maintenance of their favorite framework's integrations. More details to come!

@glasser glasser closed this as completed Dec 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants