Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite google cloud functions to just use apollo-server-express #5292

Closed
glasser opened this issue Jun 9, 2021 · 0 comments
Closed

Rewrite google cloud functions to just use apollo-server-express #5292

glasser opened this issue Jun 9, 2021 · 0 comments

Comments

@glasser
Copy link
Member

glasser commented Jun 9, 2021

No description provided.

glasser added a commit that referenced this issue Jun 9, 2021
You know how we recently changed apollo-server-lambda to be a thin
wrapper around apollo-server-express? That was a bit fiddly because we
needed to pull in a third-party package to translate Lambda objects into
Express objects.

Turns out we can do the same thing for Google Cloud Functions... except
even easier, because GCF gives us Express objects already!

Note that this PR has not been fixed in a real GCF environment.

Fixes #5292.
glasser added a commit that referenced this issue Jun 9, 2021
You know how we recently changed apollo-server-lambda to be a thin
wrapper around apollo-server-express? That was a bit fiddly because we
needed to pull in a third-party package to translate Lambda objects into
Express objects.

Turns out we can do the same thing for Google Cloud Functions... except
even easier, because GCF gives us Express objects already!

Note that this PR has not been tested in a real GCF environment.

Fixes #5292.
@glasser glasser closed this as completed Jun 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant