Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground: Resize schema panel #2529

Closed
joseluisq opened this issue Apr 4, 2019 · 11 comments · Fixed by apollographql/graphql-playground#19 or #3224
Closed

Playground: Resize schema panel #2529

joseluisq opened this issue Apr 4, 2019 · 11 comments · Fixed by apollographql/graphql-playground#19 or #3224
Milestone

Comments

@joseluisq
Copy link

Now I' using apollo-server-express v2.3.1. I can resize the schema panel once but when I choose some query in the right then I can not resize it anymore and the panel returns to its original position.

I would be great if the schema panel could have the same resize functionality as editor panel and to persist the resize position if I refresh the page later.

@JacksonKearl
Copy link

The GraphQL Playground is actually a separate project under different ownership, located at https://github.com/prisma/graphql-playground.

Closing this for now - definitely an issue over on the project's repository if this is still a concern for you.

@websolutions-hamburg
Copy link

Maybe it's a problem of the Apollo Fork from the Prisma Playground. Because the current Prisma Playground v1.7.20 works correct.
With apollo-server-express: "2.6.9" it also works correct. But since v2.7.0 it doesn't work. If you try to change the schema panel size, you now get the following error in the console:

SideTabs.tsx:216 Uncaught TypeError: n.props.changeWidthDocs is not a function
    at HTMLDocument.i (SideTabs.tsx:216)

image

@websolutions-hamburg
Copy link

This issue still exists with:

apollo-server-express : 2.8.0
apollo playground fork: 1.7.30

@JacksonKearl JacksonKearl reopened this Jul 31, 2019
@abernix
Copy link
Member

abernix commented Aug 24, 2019

@spencersteers The "prisma" link you've referenced above is not the current state of (their) master:

This is master (and a perma link to it at the time of this writing, just in case it changes)

Where did you get the 5fa7d83 Git hash that you referenced?

@abernix
Copy link
Member

abernix commented Aug 24, 2019

It looks like it was removed, relatively recently, in graphql/graphql-playground#1001.

Perhaps @yoshiakis could provide some insight/justification on this?

@spencersteers
Copy link

spencersteers commented Aug 24, 2019

@abernix My bad - not sure how I ended up there.

Looking at the latest release though the action is still being bound (v1.8.10 SideTabs.tsx)

Digging a bit deeper all the commits currently going into master have the resize issue. I pulled master and added the action back in and it seems to be working. Maybe master just isn't stable and it is on their radar.

@abernix
Copy link
Member

abernix commented Aug 24, 2019

@spencersteers Would you consider opening a PR for the fix to either the upstream or our fork (and maybe most preferably, out of a matter of timeliness, both?)

If you can, I can probably ship a patch for this fairly quickly.

@spencersteers
Copy link

@abernix Sure, can do.

abernix added a commit that referenced this issue Aug 28, 2019
Via an upstream PR provided by @spencersteers, this fixes a regression in
GraphQL Playground which prevented the resizing of the schema panel.  This
regression seems to have been introduced by
graphql/graphql-playground#1001, which removed the
relevant binding.

See referenced issues for additional details into the change.

Ref: apollographql/graphql-playground#19
Fixes: #2529
abernix added a commit that referenced this issue Aug 28, 2019
Via an upstream PR provided by @spencersteers, this fixes a regression in
GraphQL Playground which prevented the resizing of the schema panel.  This
regression seems to have been introduced by
graphql/graphql-playground#1001, which removed the
relevant binding.

See referenced issues for additional details into the change.

Ref: apollographql/graphql-playground#19
Fixes: #2529
abernix added a commit that referenced this issue Aug 28, 2019
Via an upstream PR provided by @spencersteers, this fixes a regression in
GraphQL Playground which prevented the resizing of the schema panel.  This
regression seems to have been introduced by
graphql/graphql-playground#1001, which removed the
relevant binding.

See referenced issues for additional details into the change.

Ref: apollographql/graphql-playground#19
Fixes: #2529
@yoshiakis
Copy link

yoshiakis commented Aug 30, 2019

@spencersteers Thank you for creating PR for fixing the regression I've introduced!

@abernix abernix added this to the Release 2.9.1 milestone Aug 30, 2019
@abernix
Copy link
Member

abernix commented Aug 30, 2019

This should be fixed in the GraphQL Playground that's referenced from Apollo Server 2.9.1 if anyone wouldn't mind testing it and reporting back!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
6 participants