-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playground: Resize schema panel #2529
Playground: Resize schema panel #2529
Comments
The GraphQL Playground is actually a separate project under different ownership, located at https://github.com/prisma/graphql-playground. Closing this for now - definitely an issue over on the project's repository if this is still a concern for you. |
Maybe it's a problem of the Apollo Fork from the Prisma Playground. Because the current Prisma Playground v1.7.20 works correct.
|
This issue still exists with:
|
Looks like it isn't binding the action. |
@spencersteers The "prisma" link you've referenced above is not the current state of (their) This is Where did you get the |
It looks like it was removed, relatively recently, in graphql/graphql-playground#1001. Perhaps @yoshiakis could provide some insight/justification on this? |
@abernix My bad - not sure how I ended up there. Looking at the latest release though the action is still being bound (v1.8.10 SideTabs.tsx) Digging a bit deeper all the commits currently going into master have the resize issue. I pulled master and added the action back in and it seems to be working. Maybe master just isn't stable and it is on their radar. |
@spencersteers Would you consider opening a PR for the fix to either the upstream or our fork (and maybe most preferably, out of a matter of timeliness, both?) If you can, I can probably ship a patch for this fairly quickly. |
@abernix Sure, can do. |
Via an upstream PR provided by @spencersteers, this fixes a regression in GraphQL Playground which prevented the resizing of the schema panel. This regression seems to have been introduced by graphql/graphql-playground#1001, which removed the relevant binding. See referenced issues for additional details into the change. Ref: apollographql/graphql-playground#19 Fixes: #2529
Via an upstream PR provided by @spencersteers, this fixes a regression in GraphQL Playground which prevented the resizing of the schema panel. This regression seems to have been introduced by graphql/graphql-playground#1001, which removed the relevant binding. See referenced issues for additional details into the change. Ref: apollographql/graphql-playground#19 Fixes: #2529
Via an upstream PR provided by @spencersteers, this fixes a regression in GraphQL Playground which prevented the resizing of the schema panel. This regression seems to have been introduced by graphql/graphql-playground#1001, which removed the relevant binding. See referenced issues for additional details into the change. Ref: apollographql/graphql-playground#19 Fixes: #2529
@spencersteers Thank you for creating PR for fixing the regression I've introduced! |
This should be fixed in the GraphQL Playground that's referenced from Apollo Server 2.9.1 if anyone wouldn't mind testing it and reporting back! |
Now I' using
apollo-server-express v2.3.1
. I can resize the schema panel once but when I choose some query in the right then I can not resize it anymore and the panel returns to its original position.I would be great if the schema panel could have the same resize functionality as editor panel and to persist the resize position if I refresh the page later.
The text was updated successfully, but these errors were encountered: