Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql-server-express and graphql 0.8 #234

Closed
callmephilip opened this issue Dec 3, 2016 · 9 comments
Closed

graphql-server-express and graphql 0.8 #234

callmephilip opened this issue Dec 3, 2016 · 9 comments

Comments

@callmephilip
Copy link

Is there any particular reason why graphql-server-express does not support graphql 0.8 (judging from peerDependencies)

@Tallyb
Copy link
Contributor

Tallyb commented Dec 7, 2016

graphql is a dev dependency:
https://github.com/apollostack/graphql-server/blob/master/package.json#L30
Is that intentional?

@Dattaya
Copy link
Contributor

Dattaya commented Dec 7, 2016

@Tallyb, it's not in all of the packages, e.g.: https://github.com/apollostack/graphql-server/blob/master/packages/graphql-server-express/package.json#L45

@helfer
Copy link
Contributor

helfer commented Dec 7, 2016

@callmephilip no particular reason. Feel free to make a PR, and I'll release a new version!

@delaneyj
Copy link

delaneyj commented Dec 8, 2016

The npm registry needs to be updated and doesn't this actually update the version to 0.4.4 for the express package as well?

@callmephilip
Copy link
Author

@helfer can you guys please publish the new version

@secretfader
Copy link

secretfader commented Dec 13, 2016

Ping. Can we get this released to npm, @helfer?

@kachkaev
Copy link
Contributor

kachkaev commented Dec 20, 2016

ping-2 @helfer :–)

@ropsu
Copy link

ropsu commented Jan 6, 2017

ping-3 @helfer ;)

@helfer
Copy link
Contributor

helfer commented Jan 6, 2017

Really really sorry I dropped the ball on this one! 😞 There was a misunderstanding about who was going to release a new version. I'm making sure it happens now!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants