Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[apollo-engine-reporting] Support proxy servers #1836

Closed
eberhara opened this issue Oct 19, 2018 · 2 comments · Fixed by #1879
Closed

[apollo-engine-reporting] Support proxy servers #1836

eberhara opened this issue Oct 19, 2018 · 2 comments · Fixed by #1879
Labels
🧞‍♂️ enhancement ⛲️ feature New addition or enhancement to existing solutions ⁉️ question

Comments

@eberhara
Copy link
Contributor

Hey guys,
Is there any way to set apollo engine reporting metrics to go through a proxy server?

Our environment in production does not have direct access to the internet, so we cannot proceed with apollo-engine metrics for now.

I saw in an older version that proxyUrl was supported, but I do not see it in the current apollo versions.
@ghost ghost added the ✋ blocking Prevents production or dev due to perf, bug, build error, etc.. label Oct 19, 2018
@n1ru4l n1ru4l added 🧞‍♂️ enhancement ⁉️ question ⛲️ feature New addition or enhancement to existing solutions and removed ✋ blocking Prevents production or dev due to perf, bug, build error, etc.. labels Oct 19, 2018
@eberhara
Copy link
Contributor Author

Created a PR for that #1837

@eberhara eberhara mentioned this issue Oct 19, 2018
Closed
4 tasks
@eberhara
Copy link
Contributor Author

Not sure why @n1ru4l removed the blocking label since this is indeed blocking our team from going to production. Anyway, I created a PR fixing that, and it would be cool if someone could take a look at it.

@eberhara eberhara mentioned this issue Oct 25, 2018
Merged
4 tasks
abernix pushed a commit that referenced this issue Oct 26, 2018
@eberhara @abernix
feature(apollo-engine-reporting): Add custom http agent support (#1879)
b640be4 
This PR fixes #1836.

This PR enables developers to inject the http agent to be used on the network requests to apollo engine endpoint.

<!--
  Thanks for filing a pull request on GraphQL Server!

  Please look at the following checklist to ensure that your PR
  can be accepted quickly:
-->

TODO:

* [x] Update CHANGELOG.md with your change (include reference to issue & this PR)
* [x] Make sure all of the significant new logic is covered by tests
* [x] Rebase your changes on master so that they can be merged easily
* [x] Make sure all tests and linter rules pass

<!--**Pull Request Labels**

While not necessary, you can help organize our pull requests by labeling this issue when you open it.  To add a label automatically, simply [x] mark the appropriate box below:

- [ ] feature
- [ ] blocking
- [ ] docs

To add a label not listed above, simply place `/label another-label-name` on a line by itself.
-->
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🧞‍♂️ enhancement ⛲️ feature New addition or enhancement to existing solutions ⁉️ question
Projects
None yet
Milestone
No milestone
2 participants
@eberhara @n1ru4l