Toggle to remove errors from traces sent to Engine Servers #1613
Labels
⛲️ feature
New addition or enhancement to existing solutions
Comments
ghost
added
the
|
Please update this article in the Engine docs when disabling error reporting becomes available: https://www.apollographql.com/docs/engine/data-privacy.html. |
4 tasks
martijnwalraven
pushed a commit
that referenced
this issue
Sep 5, 2018
Fixes #1613. We always send traces that includes an error node if the trace has an error. In the case that sending errors is disabled, we replace the message and remove the location. Note that the Engine proxy strips all error information from the traces with noErrorTraces set. To get errors to show up in the ui, the proxy sends error counts inside of the aggregated stats reports. To get similar behavior inside of the apollo server metrics reporting, we always send a trace and mask out the PII.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We need the ability to prevent error messages and locations from being sent to the Engine Servers.
This is a feature in the engine proxy, so I would consider the lack of toggle to be a regression.
The documentation for
reportErrorFunctiondoesn't quite seem clear due to the overloading of error, representing reported errors in traces and those that occur when sending a trace to the engine backend.The text was updated successfully, but these errors were encountered: