Skip to content

Commit

Permalink
To support Node.js 6, use older version of log4js for testing.
Browse files Browse the repository at this point in the history
We're only testing the interface compatibility here, so the latest version
isn't really necessary.  Though this would be great to update!
  • Loading branch information
abernix committed Mar 16, 2020
1 parent fa93038 commit 2ca6be5
Show file tree
Hide file tree
Showing 5 changed files with 42 additions and 25 deletions.
55 changes: 31 additions & 24 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
"js-sha256": "0.9.0",
"koa": "2.11.0",
"lerna": "3.20.2",
"log4js": "6.1.2",
"log4js": "4.5.1",
"memcached-mock": "0.1.0",
"mock-req": "0.2.0",
"nock": "10.0.6",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ import * as winston from "winston";
import WinstonTransport from 'winston-transport';
import * as bunyan from "bunyan";
import * as loglevel from "loglevel";
// We are testing an older version of `log4js` which uses older ECMAScript
// in order to still support testing on Node.js 6.
// This should be updated when bump the semver major for AS3.
import * as log4js from "log4js";

const LOWEST_LOG_LEVEL = "debug";
Expand Down
3 changes: 3 additions & 0 deletions packages/apollo-server-core/src/__tests__/logger.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ import * as winston from "winston";
import WinstonTransport from 'winston-transport';
import * as bunyan from "bunyan";
import * as loglevel from "loglevel";
// We are testing an older version of `log4js` which uses older ECMAScript
// in order to still support testing on Node.js 6.
// This should be updated when bump the semver major for AS3.
import * as log4js from "log4js";

const LOWEST_LOG_LEVEL = "debug";
Expand Down
4 changes: 4 additions & 0 deletions renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@
"packageNames": ["@koa/cors"],
"allowedVersions": "<3"
},
{
"packageNames": ["log4js"],
"allowedVersions": "<5"
},
{
"packageNames": ["hapi", "@types/hapi"],
"allowedVersions": "<18"
Expand Down

0 comments on commit 2ca6be5

Please sign in to comment.