Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): object values can be empty, fixes #744 #745

Merged
merged 5 commits into from
Nov 16, 2023
Merged

fix(parser): object values can be empty, fixes #744 #745

merged 5 commits into from
Nov 16, 2023

Conversation

goto-bus-stop
Copy link
Member

@goto-bus-stop goto-bus-stop commented Nov 15, 2023 •
edited
Loading

Fixes #744, a critical regression in apollo-parser 0.7.3.

@goto-bus-stop goto-bus-stop self-assigned this Nov 15, 2023
@goto-bus-stop goto-bus-stop enabled auto-merge (squash) November 16, 2023 12:07
@goto-bus-stop goto-bus-stop merged commit ac7b5f2 into main Nov 16, 2023
@goto-bus-stop goto-bus-stop deleted the fix-empty-object-values branch November 16, 2023 12:10
@goto-bus-stop goto-bus-stop mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonSapin SimonSapin SimonSapin approved these changes

@lrlna lrlna Awaiting requested review from lrlna lrlna is a code owner

Assignees

@goto-bus-stop goto-bus-stop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in parser 0.7.3: empty object values no longer parse
2 participants
@goto-bus-stop @SimonSapin