Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): emit lexer error on escaped surrogate to avoid panic #658

Merged
merged 2 commits into from
Sep 28, 2023
Merged

fix(parser): emit lexer error on escaped surrogate to avoid panic #658

merged 2 commits into from
Sep 28, 2023

Conversation

SimonSapin
Copy link
Contributor

Fixes #608

@SimonSapin
Copy link
Contributor Author

I based this branch on main so that this PR only shows the relevant diff, but tests will fail until rebased on top of PR #652.

@SimonSapin SimonSapin enabled auto-merge (squash) September 28, 2023 13:59
@SimonSapin SimonSapin self-assigned this Sep 28, 2023
@SimonSapin SimonSapin merged commit 7719507 into main Sep 28, 2023
@SimonSapin SimonSapin deleted the surrogate branch September 28, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goto-bus-stop goto-bus-stop goto-bus-stop approved these changes

@lrlna lrlna Awaiting requested review from lrlna lrlna is a code owner

Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic with surrogate code points in EscapedUnicode
2 participants
@SimonSapin @goto-bus-stop