chore(parser): remove recursion in field parsing, fixes #514 #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
how is the fuzzer? is it happy? |
|
I forgot about it and it accidentally ran overnight so I'm pretty sure it's happy lol Just need to tweak some of the tests here that expect the old counting! |
|
Heh I couldn't get to the bottom of the issue where we continued parsing after a recursion limit was reached, but I think I just put the check in the wrong place yesterday. Got it right with fresh eyes this morning 😇 |
|
excellllllent ^_^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
selection::selection_setparser already supports parsing multiple fields, so it looks like this recursion is unnecessary. Tests pass right now but I'll also run the fuzzer for a bit to make sure.