Replace p.err with p.err_and_pop to prevent infinite loop.
#158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`operation_definition` is called in a loop where the we never progress in which tokens we're looking at. Pop while reporting the error such that progress can be made.
|
Thank you, this is great! |
lrlna
added a commit
that referenced
this pull request
Feb 7, 2022
Avoids creating an operation definition node when an unrelated token is popped off in the parsing of operation definition nodes. Additionally, we are adding an correctly testing for number of errors and definitions in the AST when a description precedes an Operation Definition. We are also adding an error test case to the test suite with a description before an operation definition.
lrlna
added a commit
that referenced
this pull request
Feb 7, 2022
Avoids creating an operation definition node when an unrelated token is popped off in the parsing of operation definition nodes. Additionally, we are adding an correctly testing for number of errors and definitions in the AST when a description precedes an Operation Definition. We are also adding an error test case to the test suite with a description before an operation definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
operation_definitionis called in a loop where the we never progressin which tokens we're looking at.
Pop while reporting the error such that progress can be made.