Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug Fix: FieldName Normalization/Denormalization & @export(as:) concurrency issue #84

Merged
merged 3 commits into from
Feb 27, 2018
Merged

🐛 Bug Fix: FieldName Normalization/Denormalization & @export(as:) concurrency issue #84

merged 3 commits into from
Feb 27, 2018

Conversation

fbartho
Copy link
Collaborator

@fbartho fbartho commented Feb 26, 2018

@fbartho
Stop using a global shared exportVariables, Extract requestContext so…
cceb93b 
… things can be properly typed.

Fixes #81
@fbartho
Fixes fieldNameNormalizer by calling it earlier
5f556c7 
Calling `fieldNameNormalizer` ourselves before letting the response escape our hands is safer, as apollo-client can't mangle it then.

Fixes: #81
Also fixes: `fieldNameNormalizer`/`Denormalizer` test-cases had some bugs.
@fbartho
Docs formatting & Changelog
a500b6c
@fbartho fbartho changed the title Fix FieldName Normalization/Denormalization & @export(as:) concurrency issue. 🐛 Bug Fix: FieldName Normalization/Denormalization & @export(as:) concurrency issue Feb 26, 2018
@fbartho fbartho mentioned this pull request Feb 26, 2018
Closed
@codecov-io
Copy link

codecov-io commented Feb 26, 2018 •
edited
Loading

Codecov Report

Merging #84 into master will decrease coverage by 0.88%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   91.43%   90.55%   -0.89%     
==========================================
  Files           2        2              
  Lines         257      254       -3     
  Branches       81       79       -2     
==========================================
- Hits          235      230       -5     
- Misses         18       20       +2     
  Partials        4        4
Impacted Files Coverage Δ
src/restLink.ts 90.51% <93.75%> (-0.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 408abea...a500b6c. Read the comment docs.

@fbartho fbartho mentioned this pull request Feb 26, 2018
Closed
@fbartho fbartho merged commit 8ffd063 into master Feb 27, 2018
@fbartho fbartho deleted the fb/fix_fieldname_normalization branch February 27, 2018 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbartho @codecov-io