Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codesandbox examples - Added qs dependencie #177

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

isacjunior
Copy link
Contributor

@isacjunior isacjunior commented Nov 26, 2018

When I tried examples in codesandbox, I see an error about qs dependencies.
This PR add qs as dependencies in examples.

@apollo-cla
Copy link

@isacjunior: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@codecov-io
Copy link

codecov-io commented Nov 26, 2018

Codecov Report

Merging #177 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #177   +/-   ##
=======================================
  Coverage   92.65%   92.65%           
=======================================
  Files           2        2           
  Lines         395      395           
  Branches      117      117           
=======================================
  Hits          366      366           
  Misses         27       27           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48af562...f17fa51. Read the comment docs.

@fbartho fbartho merged commit 2a3db30 into apollographql:master Nov 26, 2018
@fbartho
Copy link
Collaborator

fbartho commented Nov 26, 2018

Thanks a ton! @isacjunior

@isacjunior isacjunior deleted the ij/fix/qs-dependencie branch November 26, 2018 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants