Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination: use "field key" instead of "field name" #5898

Merged
merged 3 commits into from
May 17, 2024
Merged

Conversation

BoD
Copy link
Contributor

@BoD BoD commented May 16, 2024

Also add a few cache related terms to the glossary

@BoD BoD requested a review from martinbonnin as a code owner May 16, 2024 15:54
Copy link

netlify bot commented May 16, 2024

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 1978a01
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/66470ef9bd01f200084c4f02

design-docs/Glossary.md Outdated Show resolved Hide resolved
design-docs/Glossary.md Outdated Show resolved Hide resolved

### Field key

A key that uniquely identifies a field within a Record. By default composed of the field name and the arguments passed to it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, relay uses canonical name (of a field)

design-docs/Glossary.md Outdated Show resolved Hide resolved
Co-authored-by: Martin Bonnin <martin@mbonnin.net>
@BoD BoD merged commit bcb8aad into main May 17, 2024
9 checks passed
@BoD BoD deleted the cache-terminology branch May 17, 2024 08:42
BoD added a commit to BoD/apollo-kotlin that referenced this pull request Jul 1, 2024
* Use "field key" instead of "field name"

* Add a few cache related terms to the glossary

* Apply suggestions from code review

Co-authored-by: Martin Bonnin <martin@mbonnin.net>

---------

Co-authored-by: Martin Bonnin <martin@mbonnin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants