Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5777 fix ApolloClient.Builder.okHttpClient() returns null instead of this #5778

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

japhib
Copy link
Contributor

@japhib japhib commented Apr 2, 2024

See #5777

@japhib japhib requested review from martinbonnin and BoD as code owners April 2, 2024 19:16
@apollo-cla
Copy link

@japhib: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link

netlify bot commented Apr 2, 2024

👷 Deploy request for apollo-android-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 146a361

Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍 Thanks!

Copy link
Contributor

@martinbonnin martinbonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinbonnin martinbonnin merged commit 807155d into apollographql:main Apr 3, 2024
5 checks passed
BoD pushed a commit that referenced this pull request Apr 29, 2024
BoD added a commit that referenced this pull request Apr 29, 2024
(cherry picked from commit 807155d)

Co-authored-by: Jan Bergeson <jphbergeson@gmail.com>
Adudouit added a commit to BeApp/apollo-kotlin that referenced this pull request Aug 19, 2024
…ios12-compat

* commit 'b8e8bdba951b1cb9beecabfc80433d848b2c921b': (38 commits)
  release 3.8.5
  Fix mapping of the builtin Float scalar type (apollographql#6047)
  SqlNormalizedCacheFactory make sqldriver public to support Sqlcipher data encryption. (apollographql#5972)
  Update 08-add-a-details-view.mdx for additional state handling (apollographql#5975)
  adding checks for json end_document in http batching interceptors (apollographql#5892)
  adding checks for json end_document in http transport (apollographql#5894)
  [3.x] Bump okio to 3.9.0 (apollographql#5868)
  version is now 3.8.5-SNAPSHOT
  release 3.8.4
  Backport apollographql#5848 to the v3 branch (apollographql#5863)
  Backport apollographql#5840 to the v3 branch (apollographql#5861)
  Backport apollographql#5778 to the v3 branch (apollographql#5860)
  Update min version of Kotlin in README and doc (apollographql#5750)
  version is now 3.8.4-SNAPSHOT
  release 3.8.3
  Add deprecations on symbols that are getting removed in v4 (apollographql#5746)
  docs: Correct file name discrepancies in tutorial documentation (apollographql#5740)
  Ignore IOException when calling ApolloHttpCache.remove (apollographql#5730)
  Added an implementation of a missing NSURLSessionWebSocketDelegateProtocol method in the NSURLSessionWebSocketEngine that's required in order to get a web socket to successfully reopen. (apollographql#5704)
  Update plugin-configuration.mdx (apollographql#5673)
  ...

# Conflicts:
#	gradle.properties
#	libraries/apollo-runtime/src/appleMain/kotlin/com/apollographql/apollo3/network/ws/NSURLSessionWebSocketEngine.kt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants