Introduce "filesystem" sourceSet and use okio 3.9.0 #5719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
martinbonnin
force-pushed
the
okio-3-9-0
branch
from
7e145fa to
69401fb
Compare
martinbonnin
force-pushed
the
okio-3-9-0
branch
from
69401fb to
052fa50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okio
3.9.0introduces a source set that makes it possible to useFileSystem.SYSTEMwithout having toexpect/actualfor all targets 🎉 (PR)Use this to reduce our
expect/actualusage. There is now afilesystemsourceSet for all the targets that have a filesystem:NodeJsFileSystem)The only target that is not included in practice is
wasmJsfor now.Also move symbols that require a filesystem to the
filesystemsource set. This means it's not possible to call them by mistake onwasmJs. It's still possible to call them by mistake in the browser in which case they will fail at runtime.