Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog and doc updates for next version #4318

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Conversation

BoD
Copy link
Contributor

@BoD BoD commented Aug 4, 2022

No description provided.

@netlify
Copy link

netlify bot commented Aug 4, 2022

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit c107088
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/631a2da2f84f1500099504d6

@martinbonnin martinbonnin changed the title Prepare changelog for next version Changelog and doc updates for next version Aug 25, 2022
@martinbonnin martinbonnin force-pushed the next-changelog-and-doc branch 2 times, most recently from c19e17a to 9661fe0 Compare August 30, 2022 19:19
Copy link
Contributor

@jpvajda jpvajda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a few suggestions.

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
docs/source/fetching/defer.mdx Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
docs/source/fetching/defer.mdx Outdated Show resolved Hide resolved
@jpvajda jpvajda linked an issue Sep 8, 2022 that may be closed by this pull request
@jpvajda
Copy link
Contributor

jpvajda commented Sep 8, 2022

Please see apollographql/apollo-client#10079 for changes suggested from @StephenBarlow on our Web Client docs, we should apply those same changes to these Kotlin docs. @martinbonnin

@jpvajda jpvajda self-requested a review September 8, 2022 14:21
@martinbonnin
Copy link
Contributor

Port of apollographql/apollo-client#10079 is here

Co-authored-by: Martin Bonnin <martin@mbonnin.net>

add a link to the (upcoming) documentation

update date

Update docs/source/fetching/defer.mdx

Co-authored-by: JV <jvajda@apollographql.com>

Update CHANGELOG.md

Co-authored-by: JV <jvajda@apollographql.com>

Update CHANGELOG.md

Co-authored-by: JV <jvajda@apollographql.com>

Update docs/source/fetching/defer.mdx

Co-authored-by: JV <jvajda@apollographql.com>

trying to make yaml happy

update `@defer` to stage 2 draft and mention empty `hasNext: false` payloads

see #4373

updates from apollographql/apollo-client#10079

fix an instance of Client -> Kotlin
@martinbonnin martinbonnin marked this pull request as ready for review September 8, 2022 18:00
@martinbonnin martinbonnin merged commit 72de40c into main Sep 8, 2022
@martinbonnin martinbonnin deleted the next-changelog-and-doc branch September 8, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document hasNext: False response case
3 participants