Cascade out type parameters for TypeScript 4.8 #9919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DanielRosenwasser: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
| @@ -226,7 +227,7 @@ export class InMemoryCache extends ApolloCache<NormalizedCacheObject> { | |||
| } | |||
| } | |||
|
|
|||
| public diff<TData, TVariables = any>( | |||
| public diff<TData, TVariables extends OperationVariables = any>( | |||
There was a problem hiding this comment.
This could possibly be changed to
Suggested change
| public diff<TData, TVariables extends OperationVariables = any>( | |
| public diff<TData, TVariables extends OperationVariables = OperationVariables>( |
| TGraphQLVariables = {}, | ||
| TChildProps = DataProps<TData, TGraphQLVariables> | ||
| TGraphQLVariables extends {} = {}, | ||
| TChildProps extends { [x: string]: any; } = DataProps<TData, TGraphQLVariables> |
There was a problem hiding this comment.
A possible alternative:
Suggested change
| TChildProps extends { [x: string]: any; } = DataProps<TData, TGraphQLVariables> | |
| TChildProps extends Partial<DataProps<TData, TGraphQLVariables>> = DataProps<TData, TGraphQLVariables> |
or possibly, but suspiciously
Suggested change
| TChildProps extends { [x: string]: any; } = DataProps<TData, TGraphQLVariables> | |
| TChildProps extends {} = DataProps<TData, TGraphQLVariables> |
|
@DanielRosenwasser Thank you for making us aware of this change! |
|
The team discussed and we will target this for our upcoming |
1 task
|
these changes are squashed into #10041 to see if this change will help with the TS 4.8 upgrade. |
alessbell
pushed a commit
that referenced
this pull request
Jan 23, 2023
* Cascade out type parameters for TypeScript 4.8 * Add apparent fix for `graphql.tsx` by making TChildProps expect a partial type.
3 tasks
alessbell
pushed a commit
that referenced
this pull request
Jan 25, 2023
* Cascade out type parameters for TypeScript 4.8 * Add apparent fix for `graphql.tsx` by making TChildProps expect a partial type.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! 👋
TypeScript recently added some stricter checking around unconstrained generics being incompatible with emptyish object types. The changes are only in nightly versions of TypeScript right now, but we've been exploring how open-source projects have been impacted. These are the changes necessary for apollo-client to build cleanly in TypeScript 4.8.