Add defensive isMounted checks before setting state via useMutation Hook #9883
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds checks in two places inside of
useMutation
to verify that the component is mounted before setting state withsetResult
, which fixes #9858.Testing
Spying on console.error here is sufficient. I've updated the tests, which now fail if either
isMounted
check added in the PR is removed.Checklist:
If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)