Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internalize useSyncExternalStore shim, for more control than use-sync-external-store provides #9675

Merged
merged 11 commits into from
May 9, 2022
Merged

Internalize useSyncExternalStore shim, for more control than use-sync-external-store provides #9675

merged 11 commits into from
May 9, 2022

Commits on May 9, 2022

  1. Export canUseDOM from utilities/common/canUse.ts.

    @benjamn
    benjamn committed May 9, 2022
    Configuration menu
    Copy the full SHA
    c26f999 View commit details
    Browse the repository at this point in the history

  2. Roll our own shim version of useSyncExternalStore.

    @benjamn
    benjamn committed May 9, 2022
    Configuration menu
    Copy the full SHA
    9c2fb4f View commit details
    Browse the repository at this point in the history

  3. Note key deviations from original use-sync-external-store/shim.

    @benjamn
    benjamn committed May 9, 2022
    Configuration menu
    Copy the full SHA
    7392a1d View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary useSyncExternalStore shim package(s).

    @benjamn
    benjamn committed May 9, 2022
    Configuration menu
    Copy the full SHA
    6ab7750 View commit details
    Browse the repository at this point in the history

  5. Disable canUseDOM when isNode.

    @benjamn
    benjamn committed May 9, 2022
    Configuration menu
    Copy the full SHA
    c5734a9 View commit details
    Browse the repository at this point in the history

  6. Disable canUseDOM only when window.document comes from JSDOM. 

    I believe this is a more precise change than my previous commit, which
used isNode to determine canUseDOM. In most server-side rendering
setups, there will be no window.document.createElement, so canUseDOM
will already be false for that reason. It's only in Node.js environments
using jsdom that window.document.createElement might seem to be defined,
so that's the only case we really need to check.
    @benjamn
    benjamn committed May 9, 2022
    Configuration menu
    Copy the full SHA
    4edd24c View commit details
    Browse the repository at this point in the history

  7. Simple regression test that canUseDOM should remain false during tests.

    @benjamn
    benjamn committed May 9, 2022
    Configuration menu
    Copy the full SHA
    18528ed View commit details
    Browse the repository at this point in the history

  8. Distinguish between canUseDOM and canUseLayoutEffect.

    @benjamn
    benjamn committed May 9, 2022
    Configuration menu
    Copy the full SHA
    11cdb96 View commit details
    Browse the repository at this point in the history

  9. Mention PR #9675 in CHANGELOG.md.

    @benjamn
    benjamn committed May 9, 2022
    Configuration menu
    Copy the full SHA
    94b408a View commit details
    Browse the repository at this point in the history

  10. Enforce real useSyncExternalStore type signature. 

    This should mean we'll find out if anything changes in the types of
@types/use-sync-external-store that conflicts with how we use our
wrapper of the useSyncExternalStore hook.
    @benjamn
    benjamn committed May 9, 2022
    Configuration menu
    Copy the full SHA
    4fa40ec View commit details
    Browse the repository at this point in the history

  11. Bump bundlesize limit to 29.45kB (now 28.43kB).

    @benjamn
    benjamn committed May 9, 2022
    Configuration menu
    Copy the full SHA
    d0a0545 View commit details
    Browse the repository at this point in the history