Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test skip: true and useLazyQuery with options.defaultOptions #9666

Merged
merged 5 commits into from
May 3, 2022
Merged

Test skip: true and useLazyQuery with options.defaultOptions #9666

merged 5 commits into from
May 3, 2022

Conversation

benjamn
Copy link
Member

@benjamn benjamn commented May 3, 2022 •
edited
Loading

This PR started as a regression test for PR #9665, but one test led to another, and I found/fixed a few bugs along the way.

Issues potentially solved:

benjamn added 5 commits May 3, 2022 17:02
@benjamn
Improve ObservableQuery options.{f,initialF}etchPolicy default logic.
77119b0
@benjamn
Test that defaultOptions do not interfere with skipping/unskipping.
6695b02 
This test started out as a regression test for PR #9665, but it revealed
a few other problems that I will fix in the next commit, potentially
solving issue #9655 as well.
@benjamn
Move skip/standby logic back to createWatchQueryOptions.
6d3f2e6 
This makes the objects returned by createWatchQueryOptions more
consistent with each other, which prevents unnecessary calls to
this.observable.reobserve in some edge cases. To see what I'm talking
about, try reverting this commit and running 'npm test'. The test I
recently added should fail because it makes too many requests.
@benjamn
Test that useLazyQuery is not confused by defaultOptions.fetchPolicy.
7427f65
@benjamn
Simplify useLazyQuery initialFetchPolicy logic.
83cf0ef 
This fixes a bug where an incorrect value for initialFetchPolicy could
clobber the desired policy, typically resetting it to cache-first.
@benjamn benjamn added this to the v3.6.x patch releases milestone May 3, 2022
@benjamn benjamn self-assigned this May 3, 2022
@benjamn benjamn requested review from brainkim and hwillson May 3, 2022 22:02
@brainkim
Copy link
Contributor

brainkim commented May 3, 2022

Looks good!

@brainkim brainkim merged commit a9c7c36 into main May 3, 2022
benjamn added a commit that referenced this pull request May 3, 2022
@benjamn
Merge pull request #9666 from test-skip-unskip-and-useLazyQuery-with-…
c93a8cc 
…defaultOptions
benjamn added a commit that referenced this pull request May 3, 2022
@benjamn
Mention PR #9666 in CHANGELOG.md.
9bcbdae
@benjamn benjamn deleted the test-skip-unskip-and-useLazyQuery-with-defaultOptions branch May 3, 2022 22:33
@benjamn benjamn mentioned this pull request May 3, 2022
Closed
@benjamn benjamn linked an issue May 3, 2022 that may be closed by this pull request
useLazyQuery executes query twice the first time on 3.6.x #9655
Closed
@benjamn benjamn mentioned this pull request May 3, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brainkim brainkim Awaiting requested review from brainkim

@hwillson hwillson Awaiting requested review from hwillson

Assignees

@benjamn benjamn

Labels
🧪 has-tests ⚛️ React-related
Projects
None yet
Milestone
v3.x.x patch releases
Development

Successfully merging this pull request may close these issues.

useLazyQuery executes query twice the first time on 3.6.x
2 participants
@benjamn @brainkim