Let addTypenameToDocument take any ASTNode (including DocumentNode, as before)
#9595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
added
the
🥚 backwards-compatible
|
Thank you! That's perfect! |
glasser
reviewed
Apr 11, 2022
| export const addTypenameToDocument = Object.assign(function ( | ||
| doc: DocumentNode | ||
| ): DocumentNode { | ||
| return visit(checkDocument(doc), { |
There was a problem hiding this comment.
Is it worth checking that doc.kind is a string, to protect against passing in strings by accident? Or is it unlikely that anyone is going to be passing a string into this function from JS.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @AnthonyMDev.