-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct GraphQL variable name "text" to "type" #9529
Conversation
@FumioNonaka-ksj: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
If The |
The variable name is inconsistent with "the completed version of the app". I spent more than an hour to have my trial app work. Then, please revise "Mutations > Example app final" of CodeSandbox. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and doubled checked this change and this PR is a good adjustment as the examples we provide in code sandbox do use type
so to be consistent this is a good change, especially when someone is working through our code samples and docs to learn. We appreciate the effort to fix this!
the complete version of the app is here: https://codesandbox.io/s/mutations-example-app-final-tjoje
the starter version of the app is here: https://codesandbox.io/s/mutations-example-app-start-gm7i5
they both use type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consistency across the tutorial materials is the goal, so I'm fine with switching to type
instead of text
as long as we're consistent!
In the CodeSandbox example of "Mutations in Apollo Client", the correct variable name is "type" instead of "text". https://codesandbox.io/s/mutations-example-app-final-tjoje
In the CodeSandbox example of "Mutations in Apollo Client", the correct variable name is "type" instead of "text".
https://codesandbox.io/s/mutations-example-app-final-tjoje
Checklist: