Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct batching types #9305

Closed
wants to merge 1 commit into from
Closed

Correct batching types #9305

wants to merge 1 commit into from

Conversation

sztadii
Copy link
Contributor

@sztadii sztadii commented Jan 13, 2022

No description provided.

@sztadii
Copy link
Contributor Author

sztadii commented Jan 18, 2022

@benjamn can you approve this PR or assign someone who can look at it?

@benjamn benjamn self-requested a review January 18, 2022 17:21
@benjamn
Copy link
Member

benjamn commented Jan 18, 2022

@sztadii Since there seems to be some overlap between this PR and #9248, I would love to hear what you think of those changes (while you still have context), especially the introduction of QueuedRequest as a subtype of BatchedRequest.

@sztadii
Copy link
Contributor Author

sztadii commented Jan 18, 2022

@benjamn you are right. There are some overlaps :(
Unfortunately, I did not get a chance to look deeper into the repo.
So I did not get an opinion about #9248.
Propably I will write types in a different way to avoid duplication.

@sztadii
Copy link
Contributor Author

sztadii commented Jan 18, 2022

Let's close this PR for now.

@sztadii sztadii closed this Jan 18, 2022
@sztadii sztadii deleted the correct-other-types branch January 18, 2022 22:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benjamn benjamn Awaiting requested review from benjamn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sztadii @benjamn