Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow FieldFunctionOptions to be passed as Type Argument for FieldPolicy #9000

Merged
merged 2 commits into from
Nov 3, 2021

Conversation

VictorGaiva
Copy link
Contributor

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

Description

Allows FieldFunctionOptions definition to be passed down to FieldPolicy, FieldReadFunction and FieldMergeFunction so it can be manually defined by the developer.

Use case

Would allow apollo-client-helpers plugin to specify TArgs for each FieldPolicy, currently defined as any.

@apollo-cla
Copy link

@VictorGaiva: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@VictorGaiva VictorGaiva changed the title Provide FieldFunctionOptions to be passed as Type Argument Allow FieldFunctionOptions to be passed as Type Argument for FieldPolicy Nov 2, 2021
Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great—thanks @VictorGaiva!

@benjamn benjamn added this to the v3.4.x patch releases milestone Nov 3, 2021
@benjamn benjamn merged commit 015c403 into apollographql:main Nov 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants