Warn when calling refetch({ variables })
instead of refetch(variables)
#8702
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
refetch
method ofObservableQuery
takes a single optional positional argument, specifying (additional) variables to include when refetching the query.A common pitfall is passing an object containing a
variables
property torefetch
(you may be thinking ofsetOptions
?), which is almost always a mistake, unless the query declares a variable named$variables
(uncommon).This PR displays a helpful warning in these cases (with tests to prove it). For example:
Related: