Default to current object for readField only when from omitted.
#8508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should help with #8499.
|
|
benjamn
added a commit
that referenced
this pull request
Jul 23, 2021
Fixing a regression introduced by #8508. Importing from @apollo/client/testing in cache/inmemory/policies.ts made Rollup display circular dependency warnings (which are often harmless but also worth avoiding) and resulted in importing React-related code even when using @apollo/client/core rather than @apollo/client, which is a more serious problem.
|
Thanks so much @benjamn, just saw this error come through in one of our tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help with #8499, by making
readFieldnot suddenly fall back to reading from the current object when the caller attempts to pass a value for thefromoption/argument but ends up passing undefined. ThereadFieldfunction also now prints a warning when this situation occurs.@willrax Is this what you had in mind? Specifically, you want both the warning and the behavior change of not defaulting to
objectOrReferencewhenfromis explicitly passed (but undefined)?