Deep merge toBeAdded type policies #8361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Banou26: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
benjamn
reviewed
Jun 8, 2021
There was a problem hiding this comment.
Thanks for tracking this down and finding a solution and adding tests @Banou26!
I think I'm at fault here for not realizing the compact helper function would produce different results than just calling updateTypePolicy multiple times in a row (which works). Sorry about that!
I'm also sorry for keeping you waiting on #7535. Thanks for your patience.
benjamn
approved these changes
Jun 8, 2021
|
@Banou26 thank you so much for this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7535
This PR deep-merge
toBeAddedtypePolicies instead of shallowly merging themcc @brainkim