Reactivate reactive variables when InMemoryCache acquires first watcher. #7657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug introduced by #7279, which was triggered by calling this.cancel() before re-watching in the QueryInfo#updateWatch method, causing cache.watches.size to drop to zero temporarily, thereby invoking forgetCache(cache). When this happened, reactive variables would stop broadcasting updates to the forgotten cache, even though the unwatching was only momentary, and would not begin broadcasting again until the association was reestablished by other means. This new implementation uses a WeakMap to remember the association between caches and sets of reactive variables, which makes it possible to recall those associations later, provided the cache has not been garbage collected in the meantime.
benjamn
changed the title
benjamn
force-pushed
the
reactivate-reactive-variables
branch
from
c2e50a9
to
8b248ab
Compare
hwillson
approved these changes
Feb 5, 2021
This was referenced Feb 5, 2021
This was referenced Mar 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced by #7279, which was triggered by calling
this.cancel()before re-watching in theQueryInfo#updateWatchmethod, causingcache.watches.sizeto drop to zero temporarily, thereby invokingforgetCache(cache). When this happened, reactive variables would stop broadcasting updates to the forgotten cache, even though the unwatching was only momentary, and would not begin broadcasting again until the association was reestablished by other means.This new implementation uses a
WeakMapto remember associations between caches and sets of reactive variables, which makes it possible to recall those associations later, provided the cache has not been garbage collected in the meantime.Should fix #7593 and #7630, though #7622 remains a concern.